nixos/postgresql: drop ensurePermissions option #287602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
RaitoBezarius
approved these changes
Feb 10, 2024
delroth
added
the
12.approvals: 1
| @@ -161,33 +161,6 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| ensurePermissions = mkOption { | |||
There was a problem hiding this comment.
Shouldn't we have a mkRemovedOption?
There was a problem hiding this comment.
@SuperSandro2000 do you know how to reasonably implement this for submodules? I'm not aware of any way sadly.
There was a problem hiding this comment.
We can't just place mkRemovedOptionModule in the submodule? 😅
There was a problem hiding this comment.
It generates a config.assertions block next to the options.option_that_is_removed and this won't work in a submodule.
...effectively what was planned already in NixOS#266270, but it was too late because the branches were restricted and didn't allow any breaking changes anymore. It also suffers from the same issue that we already had when discussing this the last time[1] when `ensureDBOwnership` was ultimately introduced as band-aid fix: newly created users don't get CREATE permission on the `public` schema anymore (since psql 15), even with `ALL PRIVILEGES`. If one's use-case is more sophisticated than having a single owner, it's questionable anyways if this module is the correct tool since permissions aren't dropped on a change to this option or a removal which is pretty surprising in the context of NixOS. [1] NixOS#266270
Ma27
force-pushed
the
drop-postgres-ensurePermissions
branch
from
0a6d0b5
to
d363f52
Compare
delroth
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
...effectively what was planned already in #266270, but it was too late because the branches were restricted and didn't allow any breaking changes anymore.
It also suffers from the same issue that we already had when discussing this the last time[1] when
ensureDBOwnershipwas ultimately introduced as band-aid fix: newly created users don't get CREATE permission on thepublicschema anymore (since psql 15), even withALL PRIVILEGES.If one's use-case is more sophisticated than having a single owner, it's questionable anyways if this module is the correct tool since permissions aren't dropped on a change to this option or a removal which is pretty surprising in the context of NixOS.
[1] #266270
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.